feat: support plain old node as strategy to get node version#2142
Merged
seefood merged 4 commits intoBash-it:masterfrom Nov 7, 2024
Merged
feat: support plain old node as strategy to get node version#2142seefood merged 4 commits intoBash-it:masterfrom
seefood merged 4 commits intoBash-it:masterfrom
Conversation
Contributor
Author
|
FYI, existing tests pass, but there are no tests for powerline's |
Member
|
When ever we touch stuff related to language interpreters, I like to bring up the need to support shims, which is how a lot of these version managers work now. |
Contributor
Author
What does this mean with respect to this PR? |
NoahGorny
requested changes
May 18, 2022
Member
NoahGorny
left a comment
There was a problem hiding this comment.
Hi @matthewadams, thanks for your contribution!
I left a comment, but I am looking forward to merge this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
node --versionas a strategy to get the node version. Current code assumesnvmis in use.Description
Add function
node_native_version_promptto usenode --version& refactornode_version_promptto use new envvarNODE_VERSION_STRATEGYwith valuesnvm(default) ornodeto call eithernvm_version_promptornode_native_version_prompt, respectively.Motivation and Context
Current code assumes
nvmmanagesnode. I useasdf.How Has This Been Tested?
Tested locally.
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.