Skip to content

plugin/ruby shellcheck#1955

Merged
NoahGorny merged 2 commits intoBash-it:masterfrom
gaelicWizard:plugin-ruby
Sep 28, 2021
Merged

plugin/ruby shellcheck#1955
NoahGorny merged 2 commits intoBash-it:masterfrom
gaelicWizard:plugin-ruby

Conversation

@gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 19, 2021 •
edited
Loading

Description

Quote some things and handle unbound parameters.

Motivation and Context

This was part of my _command_exists branch (#1938) but was out of scope.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as draft September 19, 2021 17:51
@gaelicWizard gaelicWizard changed the title Plugin ruby DRAFT: plugin/ruby improvements Sep 19, 2021
@gaelicWizard gaelicWizard changed the title DRAFT: plugin/ruby improvements DRAFT: plugin/ruby shellcheck Sep 19, 2021
@gaelicWizard gaelicWizard force-pushed the plugin-ruby branch 2 times, most recently from 45ff096 to 778b65e Compare September 20, 2021 05:07
@gaelicWizard gaelicWizard changed the title DRAFT: plugin/ruby shellcheck plugin/ruby shellcheck Sep 20, 2021
@gaelicWizard gaelicWizard marked this pull request as ready for review September 20, 2021 05:08
davidpfarrell
davidpfarrell suggested changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings !

The fixes to the ruby plugin seems mostly legit. Always glad to get more files into the clean_files.txt !

I have one comment on the "${1?}" usage.

Also, what are the empty files in this PR? Permission changes? They don't seem releveant to this PR.

If this is a stacked PR waiting on another PR to merge first, then lets label it DRAFT for now ...

@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Sep 22, 2021

Also, what are the empty files in this PR? Permission changes? They don't seem releveant to this PR.

If this is a stacked PR waiting on another PR to merge first, then lets label it DRAFT for now ...

I always mark it a draft in the GitHub UI and add "DRAFT" to the title until it's parent branch is approved. I've just rebased this on master and it's now ready to go.

davidpfarrell
davidpfarrell approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I can tell this looks baked and ready to go !

NoahGorny
NoahGorny approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Great work @gaelicWizard and great review @davidpfarrell 😄

@NoahGorny NoahGorny merged commit 198df80 into Bash-it:master Sep 28, 2021
@gaelicWizard gaelicWizard deleted the plugin-ruby branch September 29, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

+1 more reviewer

@davidpfarrell davidpfarrell davidpfarrell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaelicWizard @NoahGorny @davidpfarrell