Themes: use _save-and-reload-history()#1941
Merged
NoahGorny merged 2 commits intoBash-it:masterfrom Sep 16, 2021
Merged
Conversation
First pass to use _Bash It_'s automatic history management.
4ecd84c to
9d65674
Compare
NoahGorny
approved these changes
Sep 15, 2021
Member
NoahGorny
left a comment
There was a problem hiding this comment.
Nice work!
This should not change any behaviour, right?
Contributor
Author
In this PR, I specifically only replaced calls to all three lines with the function that calls all three lines. There should be absolutely no behavior changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
with a single call to
_save-and-reload-history()in all themes. Alsö, remove executable bit.Motivation and Context
This is inspired by #1595 and does not depend on #1940, so I made a separate PR.
How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.