Add history flushes on each command to the powerline themes#1883
Add history flushes on each command to the powerline themes#1883NoahGorny merged 3 commits intoBash-it:masterfrom
Conversation
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Greetings! Always great to see ppl improving the Powerline themes :)
I'll look into this a bit more later, but I wanted to leave a comment that jumped to mind during a quick view of the PR.
ira-at-work
force-pushed
the
ira/autosave-history-plml
branch
from
e4a5948 to
10713d5
Compare
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
OK I had a chance to further-review the changes and have some final feedback.
Lemme know if you have any questions.
|
@ira-bv this is a great PR- if you could address the comments from @davidpfarrell I will surely merge this sooner then later ! let me know what you think 😄 |
|
Hey @NoahGorny , I know we want to give @ira-bv some time to reply/work on this, but I wanted to put this out there now while I'm thinking of it: Please don't close this PR due to inactivity - If @ira-bv can't make it back to address the changes, I'll pick it up and take it over the line. My requested changes are pretty light and I think the PR is valuable to my beloved powerline themes :) Thanks! |
|
Sorry, I was AFK for a week. I'll try to split this up and clean up this week. |
|
gentle ping @ira-bv 😄 |
ira-at-work
force-pushed
the
ira/autosave-history-plml
branch
from
3d2c3bb to
9f4c71d
Compare
|
breaking up the PR |
davidpfarrell
left a comment
davidpfarrell
left a comment
There was a problem hiding this comment.
Thanks for following up !
|
@ira-bv, please rebase on the latest master in order to fix the broken ci |
…autosave-history-plml * 'master' of https://github.com/bash-it/bash-it: (114 commits) ci: Bump go to 1.17 from 1.14 skip go tests when go is not available plugins: Add ble.sh plugin clean up pyenv plugin Lint: prepare `lib/utilities` for `shellcheck` (Bash-it#1933) plugin/base: improvements (Bash-it#1930) plugins/percol: `bind` completion/git: `shfmt` && `shellcheck` completion/git: expand search range plugin/percol: `shellcheck` & `shfmt` plugins/percol: use `_command_exists` completion/pip: simplify code flow plugin/less-pretty-cat: remove `|| cat` completion/wpscan: simplify code flow (whitespace) plugins/less-pretty-cat: simplify code flow plugins/less-pretty-cat: use `_command_exists` lib/helpers: cite `_bash-it-find-in-ancestor()` gradle: adopt `_bash_it_find_in_ancestor()` lib/helpers: new function `_bash-it-find-in-ancestor()` completion/laravel: simplify code flow ...
|
May be superseded by #1951? |
I think it would be better to merge this one (#1883) than to wait for #1951. I expect there'll be a lot of discussion about how "automatic" it should be, and there's at least one idea that I really like from @cornfeedhobo that I haven't even implemented yet. |
|
well, merge away... |
5 participants
Description
History autosave enabled for a few more themes I use.
Motivation and Context
Was only supported by one theme, I wanted it on the powerline-multiline too.
How Has This Been Tested?
I eat my own dogfood :-)
Types of changes
Checklist: