Skip to content

Conversation

@sidrao2006
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Dependency changes

⤵️ What is the current behavior?

Uses git:// url

🆕 What is the new behavior (if this is a feature change)?

Switch to https:// url

💥 Does this PR introduce a breaking change?

No (dependency update in example)

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

Unauthenticated git protocol is no longer supported.

https://github.blog/2021-09-01-improving-git-protocol-security-github/

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #372 (f2655a2) into develop (205387b) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #372      +/-   ##
===========================================
+ Coverage    75.28%   75.39%   +0.10%     
===========================================
  Files           23       22       -1     
  Lines          692      691       -1     
===========================================
  Hits           521      521              
+ Misses         171      170       -1     
Impacted Files Coverage Δ
flutter_cache_manager/lib/src/config/config.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205387b...f2655a2. Read the comment docs.

@renefloor
Copy link
Contributor

Fixed in #368

@renefloor renefloor closed this May 16, 2022
@sidrao2006 sidrao2006 deleted the use-https-url-for-git-deps branch May 16, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants