Skip to content

Updated platform interface to have recording methods return XFile instances #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvanbeusekom merged 8 commits into from
Nov 13, 2020
Merged

Updated platform interface to have recording methods return XFile instances #9

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
613a92b
Updated platform interface to have recording methods return XFile ins…
BeMacized Nov 12, 2020
247d9c9
Update documentation and unit tests to match platform interface changes
BeMacized Nov 12, 2020
51c25b5
Make file input optional for recording methods in platform interface.…
BeMacized Nov 12, 2020
1b06322
Add missing full stop in docs.
BeMacized Nov 12, 2020
8e94057
Run dartfmt. Wrapped docs after max 80 cols. Added missing full stop.
BeMacized Nov 12, 2020
96bccd4
Updated platform interface
BeMacized Nov 13, 2020
79b58c8
Update packages/camera/camera_platform_interface/lib/src/platform_int…
BeMacized Nov 13, 2020
6c32fa9
Update packages/camera/camera_platform_interface/lib/src/platform_int…
BeMacized Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ abstract class CameraPlatform extends PlatformInterface {
}

/// Captures an image and returns the file where it was saved.
/// If no [file] parameter is provided, the file returned will be in a
/// temporary location.
Future<XFile> takePicture(int cameraId, {XFile file}) {
Future<XFile> takePicture(int cameraId) {
throw UnimplementedError('takePicture() is not implemented.');
}

Expand All @@ -79,21 +77,16 @@ abstract class CameraPlatform extends PlatformInterface {
throw UnimplementedError('prepareForVideoRecording() is not implemented.');
}

/// Starts a video recording.
///
/// If no [file] parameter is provided, the recording will be saved to a new
/// file in a temporary location.
/// Starts a video recording and returns the file where it will be saved.
///
/// The file is written on the flight as the video is being recorded.
/// If a file already exists at the path for the provided file instance,
/// an error will be thrown.
/// The file can be read as soon as [stopVideoRecording] returns it.
Future<XFile> startVideoRecording(int cameraId, {XFile file}) {
Future<XFile> startVideoRecording(int cameraId) {
throw UnimplementedError('startVideoRecording() is not implemented.');
}

/// Stops the video recording and returns the file where it was saved.
Future<XFile> stopVideoRecording(int cameraId) {
/// Stops the video recording.
Future<void> stopVideoRecording(int cameraId) {
throw UnimplementedError('stopVideoRecording() is not implemented.');
}

Expand Down