Added readonly collections rather than lists to events#111
Open
grofit wants to merge 2 commits intoBarRaider:masterfrom
Open
Added readonly collections rather than lists to events#111grofit wants to merge 2 commits intoBarRaider:masterfrom
grofit wants to merge 2 commits intoBarRaider:masterfrom
Conversation
This aligns with the events being read only (ideally records going forward).
Contributor
Author
|
This again was mentioned on #99, its optional but clearer shows the intent of the event being read only data, whereas at the moment the |
Contributor
Author
|
Didnt realise this was in limbo, have handled the merge conflicts so it should work as intended but with the more agnostic read only data type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the events being read only (ideally records going forward).