-
Notifications
You must be signed in to change notification settings - Fork 131
Allow for arrow >= 1.0.2 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have introduced a conflict between the required arrow versions from SDK and CLI: So you can not say it closes Backblaze/b2-sdk-python#201. I think we must first remove the upper bound from the SDK, before we can merge this. |
|
Sorry, I grabbed the wrong link. I meant to say it unblocks Backblaze/b2-sdk-python#204 I believe from being merged. To be fair though, the sdk doesn't require the ability to I can mirror the requirements update to the SDK but I don't know what order they'd need to be merged in for the two to be happy |
|
Backblaze/b2-sdk-python#293 is the companion update to the requirements there |
mlech-reef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog
58a7c34 to
e3f359c
Compare
Done |
a736cea to
88bffd5
Compare
|
And rebased on top of master as well |
|
Do I need to do anything else? |
|
I'm sorry, this ticket was lost in handover between me and Maciej. The linter has an issue with your vertical spacing, please see the log - you have to add a newline in one place and then we should be good to go. |
|
@sigmavirus24 please tag me when you adjust this spacing and then we'll go ahead and merge it. It makes sense to release it before 3.6 EOL :) |
88bffd5 to
99dfd2b
Compare
|
@ppolewicz reformatted! |
ppolewicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It now says A version heading needs an empty line after on line 7.
It would be faster if you ran those tests locally before pushing, I think nox allows you to run linters by nox -s lint
I can't build the linter locally: |
99dfd2b to
1674977
Compare
Add some code that allows for arrow > 1.0 so that we can stop restricting this for users relying on distribution packages. This code handles the divergent behaviour of arrow on the 1.x and 0.x branches. References Backblaze/b2-sdk-python#201 Closes Backblaze#687
1674977 to
d8d767b
Compare
|
I finally got tests running locally and got them passing. 🤞🏽 this is the last revision necessary |
|
@sigmavirus24 congratulations on the successful contribution! |
Add some code that allows for arrow > 1.0 so that we can stop
restricting this for users relying on distribution packages. This code
handles the divergent behaviour of arrow on the 1.x and 0.x branches.
Related-to Backblaze/b2-sdk-python#201
Unblocks Backblaze/b2-sdk-python#204
Closes #687