Address sanitizer/ndk28c

.github/azure-pipelines.yml

@@ -14,7 +14,7 @@ schedules:
 
 variables:
 - name: ndkVersion
-  value: 25.2.9519653
+  value: 28.2.13676358
 
 jobs:
   # WIN32
@@ -85,6 +85,13 @@ jobs:
       vmImage: 'macOS-latest'
       xCodeVersion: 16.4
 
+  - template: jobs/macos.yml
+    parameters:
+      name: 'macOS_Xcode164_Sanitizers'
+      vmImage: 'macOS-latest'
+      xCodeVersion: 16.4
+      Sanitizers: true
+
   # iOS
   - template: jobs/ios.yml
     parameters:
@@ -96,9 +103,16 @@ jobs:
   - template: jobs/ios.yml
     parameters:
       name: 'iOS_Xcode152'
-      vmImage: 'macOS-13'
+      vmImage: 'macOS-14'
       xCodeVersion: 15.2
-      simulator: 'iPhone 14'
+      simulator: 'iPhone 15'
 
   # Linux
-  - template: jobs/linux.yml
+  - template: jobs/linux.yml
+    parameters:
+      name: Ubuntu
+
+  - template: jobs/linux.yml
+    parameters:
+      name: Ubuntu_Sanitizers
+      Sanitizers: true

.github/jobs/android.yml

@@ -1,15 +1,17 @@
 parameters:
 - name: name
   type: string
+  default: ''
 - name: jsEngine
   type: string
+  default: ''
 
 jobs:
 - job: ${{parameters.name}}
   timeoutInMinutes: 30
 
   pool:
-    vmImage: macos-13
+    vmImage: macos-14
 
   steps:
   - script: |

.github/jobs/linux.yml

@@ -1,17 +1,24 @@
+parameters:
+  name: ''
+  Sanitizers: false
+
 jobs:
-- job: ubuntu
+- job: ${{parameters.name}}
   timeoutInMinutes: 15
 
   pool:
     vmImage: ubuntu-latest
 
+  variables:
+    SANITIZER_FLAG: ${{ coalesce(replace(format('{0}', parameters.Sanitizers), 'True', 'ON'), 'OFF') }}
+
   steps:
   - script: |
       sudo apt-get update
       sudo apt-get install libjavascriptcoregtk-4.1-dev libcurl4-openssl-dev ninja-build
     displayName: 'Install packages'
 
-  - script: cmake -B Build/ubuntu -GNinja -D CMAKE_BUILD_TYPE=RelWithDebInfo
+  - script: cmake -B Build/ubuntu -GNinja -D CMAKE_BUILD_TYPE=RelWithDebInfo -D ENABLE_SANITIZERS=$(SANITIZER_FLAG)
     displayName: 'Configure CMake'
 
   - script: |

.github/jobs/macos.yml

@@ -2,6 +2,7 @@ parameters:
   name: ''
   vmImage: ''
   xCodeVersion: ''
+  Sanitizers: false
 
 jobs:
 - job: ${{parameters.name}}
@@ -10,13 +11,16 @@ jobs:
   pool:
     vmImage: ${{parameters.vmImage}}
 
+  variables:
+    SANITIZER_FLAG: ${{ coalesce(replace(format('{0}', parameters.Sanitizers), 'True', 'ON'), 'OFF') }}
+
   steps:
   - script: |
       sudo xcode-select --switch /Applications/Xcode_${{parameters.xCodeVersion}}.app/Contents/Developer
     displayName: 'Select Xcode ${{parameters.xCodeVersion}}'
 
   - script: |
-      cmake -B Build/macOS -GXcode
+      cmake -B Build/macOS -GXcode -D ENABLE_SANITIZERS=$(SANITIZER_FLAG)
     displayName: 'Configure CMake'
 
   - task: Xcode@5

CMakeLists.txt

@@ -14,7 +14,7 @@ FetchContent_Declare(arcana.cpp
     GIT_TAG 1a8a5d6e95413ed14b38a6ac9419048f9a9c8009)
 FetchContent_Declare(AndroidExtensions
     GIT_REPOSITORY https://github.com/bghgary/AndroidExtensions.git
-    GIT_TAG        7d88a601fda9892791e7b4e994e375e049615688)
+    GIT_TAG        24370fff52a03ef43dcf5e5fcb8b84338b779a05)
 FetchContent_Declare(asio
     GIT_REPOSITORY https://github.com/chriskohlhoff/asio.git
     GIT_TAG f693a3eb7fe72a5f19b975289afc4f437d373d9c)

Core/AppRuntime/V8Inspector/Source/V8InspectorAgent.cpp

@@ -426,10 +426,10 @@ namespace Babylon
         }
         v8::Local<v8::String> string_value = v8::Local<v8::String>::Cast(value);
         int len = string_value->Length();
-        std::basic_string<uint16_t> buffer(len, '\0');
-        string_value->Write(v8::Isolate::GetCurrent(), &buffer[0], 0, len);
+        std::basic_string<char16_t> buffer(len, '\0');
+        string_value->Write(v8::Isolate::GetCurrent(), (uint16_t *)&buffer[0], 0, len); // Write expects uint16_t* but the template parameter is char16_t
         return v8_inspector::StringBuffer::create(
-            v8_inspector::StringView(buffer.data(), len));
+            v8_inspector::StringView((uint16_t *)buffer.data(), len));
     }
 
     bool AgentImpl::AppendMessage(

Core/Node-API/Source/js_native_api_javascriptcore.cc

@@ -18,6 +18,12 @@ struct napi_callback_info__ {
   uint16_t argc;
 };
 
+static size_t jschar_length(const JSChar* str) {
+    size_t len = 0;
+    while (str[len] != 0) { ++len; }
+    return len;
+}
+
 namespace {
   class JSString {
    public:
@@ -33,7 +39,7 @@ namespace {
     }
 
     JSString(const JSChar* string, size_t length = NAPI_AUTO_LENGTH)
-      : _string{JSStringCreateWithCharacters(string, length == NAPI_AUTO_LENGTH ? std::char_traits<JSChar>::length(string) : length)} {
+      : _string{JSStringCreateWithCharacters(string, length == NAPI_AUTO_LENGTH ? jschar_length(string) : length)} {
     }
 
     ~JSString() {

Tests/UnitTests/Android/app/src/main/cpp/CMakeLists.txt

@@ -5,6 +5,12 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 project(UnitTestsJNI)
 
+if(ENABLE_SANITIZERS)
+    set(SANITIZERS "address,undefined")
+    add_compile_options(-fsanitize=${SANITIZERS} -fno-omit-frame-pointer)
+    add_link_options(-fsanitize=${SANITIZERS})
+endif()
+
 get_filename_component(UNIT_TESTS_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../../.." ABSOLUTE)
 get_filename_component(TESTS_DIR "${UNIT_TESTS_DIR}/.." ABSOLUTE)
 get_filename_component(REPO_ROOT_DIR "${TESTS_DIR}/.." ABSOLUTE)

Tests/UnitTests/CMakeLists.txt

@@ -37,6 +37,20 @@ elseif(UNIX AND NOT ANDROID)
         Linux/App.cpp)
 endif()
 
+# Sanitizers
+option(ENABLE_SANITIZERS "Enable AddressSanitizer and UBSan" OFF)
+
+if(ENABLE_SANITIZERS)
+    set(ENABLE_RTTI ON CACHE BOOL "" FORCE)
+    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
+        set(SANITIZERS "address,undefined")
+        add_compile_options(-fsanitize=${SANITIZERS} -fno-omit-frame-pointer)
+        add_link_options(-fsanitize=${SANITIZERS})
+    else()
+        message(WARNING "Sanitizers not supported on this compiler.")
+    endif()
+endif()
+
 add_executable(UnitTests ${SOURCES} ${SCRIPTS} ${TYPE_SCRIPTS})
 target_compile_definitions(UnitTests PRIVATE JSRUNTIMEHOST_PLATFORM="${JSRUNTIMEHOST_PLATFORM}")