Skip to content

Playground: Upgrade BJS and add glTF serializer #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Playground: Upgrade BJS and add glTF serializer #1565

wants to merge 14 commits into from
+123 −43

Conversation

@alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Nov 4, 2025 •
edited
Loading

This PR adds a quick test for the glTF serializer in the Playground, updating BJS along the way.

  • Upgrade BJS to latest (8.36.1)
  • Fix installation test failure introduced in NativeEncoding: Use ArrayBufferView input and return Blob #1564
  • Add the Blob polyfill, NativeEncoding plugin, and babylonjs-serializers package throughout the Playground app
  • Port a visualization test for the glTF serializer from BJS
    • Note: I would port over more, but the rest happen to use the File API, which is not yet supported in Native.

alexchuber
alexchuber commented Nov 4, 2025
View reviewed changes
bghgary
bghgary approved these changes Nov 4, 2025
View reviewed changes
alexchuber
alexchuber commented Nov 6, 2025
View reviewed changes
@alexchuber alexchuber marked this pull request as ready for review November 6, 2025 18:10
@alexchuber
Copy link
Contributor Author

alexchuber commented Nov 6, 2025 •
edited
Loading

I think the test is failing because we're expecting the old Blob polyfill in this function
which is being called in this line

@alexchuber alexchuber changed the title Playground: Add glTF serializer test Playground: Upgrade BJS and add glTF serializer Nov 7, 2025
@alexchuber alexchuber mentioned this pull request Nov 7, 2025
Merged
alexchuber added a commit to BabylonJS/Babylon.js that referenced this pull request Nov 7, 2025
@alexchuber
NativeEngine: Support Blob in createImageBitmap (#17411)
caeae1c 
This PR adds handling for a Blob object in createImageBitmap.

We should probably outright remove the Blob hack from here, but just to
quickly & safely unblock [these other
changes](BabylonJS/BabylonNative#1565), I hope
this is alright.
@alexchuber alexchuber force-pushed the native-encoding-tests branch from 3b71a9a to 6a1def2 Compare November 8, 2025 00:54
@alexchuber
Copy link
Contributor Author

alexchuber commented Nov 8, 2025

Install tests seem to be all good.
https://dev.azure.com/babylonjs/ContinousIntegration/_build/results?buildId=45675&view=results
image

@alexchuber alexchuber enabled auto-merge (squash) November 8, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bghgary bghgary bghgary approved these changes

@CedricGuillemet CedricGuillemet Awaiting requested review from CedricGuillemet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexchuber @CedricGuillemet @bghgary @Debugmi