Skip to content

Update arcana.cpp, bgfx, JsRuntimeHost to latest #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2025
Merged

Update arcana.cpp, bgfx, JsRuntimeHost to latest #1561

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be1cabf
Update arcana.cpp, bgfx, JsRuntimeHost to latest
bghgary Oct 30, 2025
c4c43ed
🤦‍♂️
bghgary Oct 30, 2025
9824691
Update bgfx
bghgary Oct 31, 2025
cdf8cc8
Work around crash when running bgfx headless on macOS
bghgary Nov 4, 2025
98d9a07
Update bgfx to latest to pick up macOS headless fix
bghgary Nov 4, 2025
5c0f8fd
Use noop renderer when no window and no size
bghgary Nov 5, 2025
0e8fcef
Update to lastest bgfx
bghgary Nov 6, 2025
add0f5d
Merge branch 'update-deps' of https://github.com/bghgary/BabylonNativ…
bghgary Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ FetchContent_Declare(AndroidExtensions
GIT_TAG 66520bff9b57030b67894a4934d18ad7e161ba6f)
FetchContent_Declare(arcana.cpp
GIT_REPOSITORY https://github.com/microsoft/arcana.cpp.git
GIT_TAG 1a8a5d6e95413ed14b38a6ac9419048f9a9c8009)
GIT_TAG c726dbe58713eda65bfb139c257093c43479b894)
FetchContent_Declare(arcore-android-sdk
GIT_REPOSITORY https://github.com/google-ar/arcore-android-sdk.git
GIT_TAG 98cb803de5482fb2b36effe8be3b5a0d3b726976)
Expand All @@ -23,7 +23,7 @@ FetchContent_Declare(base-n
GIT_TAG 7573e77c0b9b0e8a5fb63d96dbde212c921993b4)
FetchContent_Declare(bgfx.cmake
GIT_REPOSITORY https://github.com/BabylonJS/bgfx.cmake.git
GIT_TAG ed8e11f781024120980cdbbc5871cb2ce2f63423)
GIT_TAG 468e9f8016a52498af261af594f1e2840ad5a7a3)
FetchContent_Declare(CMakeExtensions
GIT_REPOSITORY https://github.com/BabylonJS/CMakeExtensions.git
GIT_TAG ea28b7689530bfdc4905806f27ecf7e8ed4b5419)
Expand All @@ -37,7 +37,7 @@ FetchContent_Declare(ios-cmake
GIT_TAG 4.5.0)
FetchContent_Declare(JsRuntimeHost
GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git
GIT_TAG ef57990dc5533990b2bb194978a12f8c8d83565c)
GIT_TAG 7964539e733a5cd2cbae7e0155f5391d64a9d45d)
FetchContent_Declare(SPIRV-Cross
GIT_REPOSITORY https://github.com/BabylonJS/SPIRV-Cross.git
GIT_TAG 6abfcf066d171e9ade7604d91381ebebe4209edc)
Expand Down
12 changes: 11 additions & 1 deletion Core/Graphics/Source/DeviceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,17 @@ namespace Babylon::Graphics
m_state.Bgfx.Initialized = false;

auto& init = m_state.Bgfx.InitState;
init.type = s_bgfxRenderType;

// Use the noop renderer if the configuration has no window and no size.
if (config.Window == WindowT{} && config.Width == 0 && config.Height == 0)
{
init.type = bgfx::RendererType::Noop;
}
else
{
init.type = s_bgfxRenderType;
}

init.resolution.reset = BGFX_RESET_VSYNC | BGFX_RESET_MAXANISOTROPY | BGFX_RESET_FLIP_AFTER_RENDER;
init.resolution.maxFrameLatency = 1;

Expand Down