wallet cache provider#91
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=======================================
- Coverage 4.7% 4.4% -0.3%
=======================================
Files 24 24
Lines 2341 2478 +137
=======================================
Hits 110 110
- Misses 2231 2368 +137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| pub layer2: Vec<L2>, | ||
| } | ||
|
|
||
| impl<L2: Layer2Cache> WalletCache<L2> { |
There was a problem hiding this comment.
Why do we delete these whole block? I use it in my projects, and there may be other users
There was a problem hiding this comment.
i'm not delete these codes, there were move to WalletProvider trait as default methods
|
The existing persistence provider for |
1 because of we are use async to store , so we will store the wallet data structs our self In this PR, I’ve made an effort to preserve the original wallet cache interface and functionality, so it does not affect other libraries that depend on bp-wallet—or if it does, the impact is minimal, such as the small changes in rgb-runtime. |
We have implemented our own wallet cache along with the corresponding synchronization mechanism. Therefore, we need to abstract the wallet cache interface, allowing us to separate the internal data structures from the wallet and, conversely, reconstruct the wallet from those data structures.