Closed
Conversation
dr-orlovsky
requested changes
Jan 15, 2025
Member
There was a problem hiding this comment.
Concept NACK: we do not need non-standard Baid64 encoding, which is not used in bitcoin, to be a part of this library. Also, non-standard encoding of addresses doesn't belong here.
This library must know and assume nothing about RGB - it was designed in this way and must remain so.
Contributor
Author
|
Sorry, I thought that by removing the close method this became a structure for standard bitcoin addresses. I will move it back to where it was before. |
Contributor
Author
|
This should be not needed anymore, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a v0.11 fixes epic, see RGB-WG/rgb-tests#30 for an overview.