Synchronize after copying in 2D reduced diagnostics #5726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeriforme
added
bug
WeiqunZhang
reviewed
Mar 4, 2025
| } | ||
|
|
||
| d_data_2D.copy(m_h_data_2D); | ||
| Gpu::streamSynchronize(); |
Member
There was a problem hiding this comment.
This sync is not needed, because there is a sync in WarpXParIter constructor later.
RemiLehe
reviewed
Mar 4, 2025
RemiLehe
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Gpu::streamSynchronize();after copyingTableDatafrom either host-to-device and device-to-host in theParticleHistogram2DandDifferentialLuminosity2Dreduced diagnostics.We have observed unstable behaviors with the
DifferentialLuminosity2Ddiagnostic and @RemiLehe suggested this could be a reason.Marked as bug, unless otherwise recommended.