Quad spin push #1219
Open
Quad spin push #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
qianglbl
approved these changes
Nov 18, 2025
ax3l
reviewed
Nov 20, 2025
| using namespace amrex::literals; // for _prt | ||
|
|
||
| // Compute quaternion coefficients | ||
| amrex::ParticleReal angle = std::sqrt(lambdax*lambdax+lambday*lambday+lambdaz*lambdaz); |
Member
There was a problem hiding this comment.
Can the angle ever be zero (e.g., for m_k == 0)?
Member
Author
There was a problem hiding this comment.
Yes, it can. I handle that case in lines 55-57 below.
Co-authored-by: Axel Huebl <[email protected]>
cemitch99
commented
Nov 20, 2025
src/elements/Quad.H
Outdated
| */ | ||
| template<typename T_Real=amrex::ParticleReal, typename T_IdCpu=uint64_t> | ||
| AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE | ||
| void operator() ( |
Member
Author
There was a problem hiding this comment.
Change to a named function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the update of the spin vector in a (linear) Quad element.
This relies on PR#1226.