-
Notifications
You must be signed in to change notification settings - Fork 10
Add Support for Editing Unique Names #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Editing Unique Names #518
Conversation
… Links, Nodes, Panels and Openings
|
@BHoMBot check installer |
|
@GCRA101 to confirm, the following actions are now queued:
|
|
Script tested on a real project. |
albertbg028
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New feature works as intended.
|
@BHoMBot check ready-to-merge |
|
@GCRA101 to confirm, the following actions are now queued:
|
|
@peterjamesnugent, @Chrisshort92, |
peterjamesnugent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I agree with the need for unique names for each element (unless I have misunderstood?). Also, a few of the methods could be consolidated given they just use Name and Guid properties.
@peterjamesnugent I discussed the use case for editing unique names with @GCRA101 earlier. Example 1: All the similar Pad foundations with similar demands can be assigned a group. However, each pad foundation, which is usually modelled as panels is further subdivided into smaller panels (meshing requirements) which currently have randomly generated unique names. If there is a feature to assign unique names, we can do so in a way that each of the sub-panels identify with the a Pad. This basically helps in post-processing the results for element design. Example 2: Same as above for bar elements which are sub-divided into smaller bar elements for meshing, but for design where we would need full buckling lengths, which is where unique names can help. Hope I am clear. |
Replace all the SetUniqueName private methods defined for bars, nodes, panels and openings with a single method taking as input a BHoMObject. Taking advantage of polymorphism, we can minimize the repetition of code within the Toolkit.
Replace all the UpdateUniqueName private methods defined for bars, nodes, panels and openings with a single method taking as input a BHoMObject. Taking advantage of polymorphism, we can minimize the repetition of code within the Toolkit.
|
thanks again for your comment. |
|
As discussed with @GCRA101 and @samuelbasimalla, this will be closed to allow #516 to take priority. The unique name attribute using part of the id doesn't help the user when they could just use
This way, the user only needs to know the tags assigned, and doesn't need to do extra work to determine the unique name assigned by the guid. For example, if I wanted to pull 100 Whereas, using the |
Issues addressed by this PR
Fixes #514
ETABS Toolkit now allows to push/pull and update objects (i.e. bars, nodes, panels, rigid links and openings) handling corresponding assignments to ETABS Unique Name via BHoM Name.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23518-AddSupportForEditingUniqueNames/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23518-AddSupportForEditingUniqueNames/TestScript.gh?csf=1&web=1&e=YijMul)?csf=1&web=1&e=YijMul
Changelog