Skip to content

Add Pull of Base Level + Support for Multiple Towers #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peterjamesnugent merged 6 commits into from
Dec 15, 2025
Merged

Add Pull of Base Level + Support for Multiple Towers #512

peterjamesnugent merged 6 commits into from
Dec 15, 2025

Conversation

@GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Oct 28, 2025 •
edited
Loading

Issues addressed by this PR

Fixes #507

Screenshot 2025-10-28 200623

ETABS Toolkit now can allow to pull all levels (including the Base Level) for all the towers that are defined in the ETABS Model (using the AllowMultipleTower feature).

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23512-AddPullBaseLevel+SupportforMultipleTowers/Test%20Script.gh?csf=1&web=1&e=G8rRvd
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23512-AddPullBaseLevel+SupportforMultipleTowers/[TestModel_22_MultiTower.EDB](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23512-AddPullBaseLevel+SupportforMultipleTowers/TestModel_22_MultiTower.EDB?csf=1&web=1&e=ydAZhq)?csf=1&web=1&e=ydAZhq

Changelog

  • Added Tower fragment
  • Added logic in Read/Level.cs to extract info about Base Level + deal with MultiTowers.

@GCRA101
Add Tower Element in ETABS_oM
097a9d4 
Tower.cs implements the IFragment interface and allows to store the name of the tower the level belongs to when it gets pulled from the ETABS model.
@GCRA101
Update Level.cs to work with Multiple Towers and pick up the Base Level
33e00dc 
The new code gets the list of Towers in the model, extracts the data regarding the base levels of the towers from the Database Tables of the models and return to the user all the levels beloning to all towers.
@GCRA101 GCRA101 self-assigned this Oct 28, 2025
@GCRA101 GCRA101 added type:feature New capability or enhancement severity:medium Slows progress, but workaround is possible labels Oct 28, 2025
@GCRA101 GCRA101 added the type:bug Error or unexpected behaviour label Oct 28, 2025
@GCRA101
Add Alternative Algorithm for ETABS16/17 in Read\Level.cs
cc31e58 
The API of ETABS v16 and v17 doesn't have the interfaces cDatabaseTables and cTower that are key to get information on levels (including the base level) when multitower feature is active.

To prevent the code from crashing, whenever the ETABS version run by the user is recognized to be v16 or v17, the original algorithm is used.

This won't return base levels and won't deal with multitowers.
@GCRA101 GCRA101 force-pushed the ETABS_Toolkit-#507-AddPullOfBaseLevel branch from cd6f144 to cc31e58 Compare October 29, 2025 17:05
@GCRA101
Copy link
Contributor Author

GCRA101 commented Nov 4, 2025

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check installer

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Nov 4, 2025

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 4, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check installer

There are 20 requests in the queue ahead of you.

@samuelbasimalla
Copy link
Contributor

samuelbasimalla commented Nov 7, 2025

Tested this on ETABS Version 22.7.0, Rhino 7

The script works as intended:

  1. The base level gets pulled when it is non-zero value (this wasn't the case before, it always pulled base level at "0" m)
  2. The levels of multiple towers gets pulled (new feature)
image

peterjamesnugent
peterjamesnugent requested changes Nov 24, 2025
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of namespace - sorry had this on pending

GCRA101 and others added 2 commits November 24, 2025 17:44
@GCRA101 @peterjamesnugent
Update ETABS_oM/Elements/Tower.cs
788bb79 
Change namespace from Elements to Fragments.

Co-authored-by: Peter Nugent <[email protected]>
@GCRA101
Move Tower.cs from Elements/ to Fragments/
f6cc38d
@GCRA101
Copy link
Contributor Author

GCRA101 commented Dec 1, 2025

@peterjamesnugent,
thanks for the comments. Moved Tower.cs from Elements/ to Fragments/
Retested the code and all works fine.
Updates in latest commit: f6cc38d

@GCRA101
Copy link
Contributor Author

GCRA101 commented Dec 1, 2025

@BHoMBot check installer

peterjamesnugent
peterjamesnugent approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes addressed.

@peterjamesnugent peterjamesnugent self-requested a review December 15, 2025 10:47
peterjamesnugent
peterjamesnugent approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerequested by mistake - still approved.

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Dec 15, 2025

@BHoMBot ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 15, 2025

@peterjamesnugent sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Dec 15, 2025

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 15, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 40ecadd into develop Dec 15, 2025
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#507-AddPullOfBaseLevel branch December 15, 2025 10:49
@BHoMBot BHoMBot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterjamesnugent peterjamesnugent peterjamesnugent approved these changes

@Chrisshort92 Chrisshort92 Awaiting requested review from Chrisshort92

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@GCRA101 GCRA101

Labels

severity:medium Slows progress, but workaround is possible type:bug Error or unexpected behaviour type:feature New capability or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base Level is not pulled when Levels is requested

4 participants

@GCRA101 @samuelbasimalla @peterjamesnugent