Skip to content

Conversation

@GCRA101
Copy link

@GCRA101 GCRA101 commented Dec 8, 2025

Issues addressed by this PR

Related to BHoM/ETABS_Toolkit#516

Screenshot 2025-12-08 180300

The SetProperty.cs component needs to have the "values" input set to list type. If users don't do it, they get returned with an error message that most engineers don't find understandable and think the component just doesn't work (...and they eventually stop using it).
Updating the error message using a more simple and specific language (in case "Tags" is the input property), will help them figuring out they need to set the values input to list.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23513-AddSupportforGroups/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23513-AddSupportforGroups/TestScript.gh?csf=1&web=1&e=NzN4CF)?csf=1&web=1&e=NzN4CF

Changelog

. Add clarifying statement in error message when Tags is the input property

@GCRA101 GCRA101 self-assigned this Dec 8, 2025
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Dec 8, 2025
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 15, 2025

@GCRA101 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @GCRA101 on ETABS_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 16, 2025

@GCRA101 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @GCRA101 on ETABS_Toolkit

@GCRA101
Copy link
Author

GCRA101 commented Dec 16, 2025

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 16, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

There are 301 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2026

@GCRA101 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @GCRA101 on ETABS_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2026

@GCRA101 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @GCRA101 on ETABS_Toolkit

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Jan 7, 2026

@GCRA101 perhaps we can upgrade the original error message to :

Engine.UI.Compute.RecordError(e, "This component failed to run properly because the inputs cannot be collected properly. Please review the access type for the parameter value.\n");

This is then applicable to lists and trees and not specific to the Tags property - not sure if this covers every exception though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants