Skip to content

Fixing OBO user error #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trwalke merged 1 commit into from
Feb 5, 2026
+23 −9
Merged

Fixing OBO user error #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@ private void NotifyCertificateSelection(
{
if (addInOptions != null)
{
await addInOptions.InvokeOnBeforeTokenAcquisitionForOnBehalfOfAsync(builder, tokenAcquisitionOptions, user!).ConfigureAwait(false);
await addInOptions.InvokeOnBeforeTokenAcquisitionForOnBehalfOfAsync(builder, tokenAcquisitionOptions, userHint!).ConfigureAwait(false);
}

AddFmiPathForSignedAssertionIfNeeded(tokenAcquisitionOptions, builder);
Expand Down
30 changes: 22 additions & 8 deletions tests/Microsoft.Identity.Web.Test/AuthorizationHeaderProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using Microsoft.Identity.Web.Test.Common.Mocks;
using Microsoft.Identity.Web.TestOnly;
using Microsoft.IdentityModel.Tokens;
using NSubstitute.Extensions;
using Xunit;

namespace Microsoft.Identity.Web.Test
Expand All @@ -25,7 +26,28 @@ public class AuthorizationHeaderProviderTests
public async Task LongRunningSessionForDefaultAuthProviderForUserDefaultKeyTest()
{
// Arrange
// Create a test ClaimsPrincipal
var claims = new List<Claim>
{
new Claim(ClaimTypes.Name, "testuser@contoso.com")
};

var identity = new CaseSensitiveClaimsIdentity(claims, "TestAuth");
identity.BootstrapContext = CreateTestJwt();
var claimsPrincipal = new ClaimsPrincipal(identity);

var tokenAcquirerFactory = InitTokenAcquirerFactoryForTest();

// Configure the extension option such that the event is subscribed to
// so the test can observe if the service provider is set in the extra parameters
tokenAcquirerFactory.Services.Configure<TokenAcquisitionExtensionOptions>(options =>
{
options.OnBeforeTokenAcquisitionForOnBehalfOf += (builder, options, user) =>
{
//verify that the ClaimsPrincipal passed in the event is the same as the one passed to CreateAuthorizationHeaderForUserAsync and that the BootstrapContext is preserved
Assert.Equal(((CaseSensitiveClaimsIdentity)claimsPrincipal.Identity!).BootstrapContext, ((CaseSensitiveClaimsIdentity)user.Identity!).BootstrapContext);
};
});
IServiceProvider serviceProvider = tokenAcquirerFactory.Build();

IAuthorizationHeaderProvider authorizationHeaderProvider =
Expand All @@ -34,15 +56,7 @@ public async Task LongRunningSessionForDefaultAuthProviderForUserDefaultKeyTest(

using (mockHttpClient)
{
// Create a test ClaimsPrincipal
var claims = new List<Claim>
{
new Claim(ClaimTypes.Name, "testuser@contoso.com")
};

var identity = new CaseSensitiveClaimsIdentity(claims, "TestAuth");
identity.BootstrapContext = CreateTestJwt();
var claimsPrincipal = new ClaimsPrincipal(identity);

// Create options with LongRunningWebApiSessionKey
var options = new AuthorizationHeaderProviderOptions
Expand Down
Loading