Skip to content

Enabling IdWeb to use ExtraBodyParameters #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2025
Merged

Enabling IdWeb to use ExtraBodyParameters #3460

merged 4 commits into from
Aug 27, 2025

Conversation

@trwalke
Copy link
Member

@trwalke trwalke commented Aug 26, 2025 •
edited
Loading

Enabling IdWeb to use ExtraBodyParameters

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Enables IdWeb to support MSAL's WithExtraBodyParameters api

Description

Updated TokenAcquistion.cs to check for extra body parameters that have been added to AcquireTokenOptions.ExtraParameters

Fixes #3463

@trwalke trwalke marked this pull request as ready for review August 26, 2025 21:31
@trwalke trwalke requested a review from a team as a code owner August 26, 2025 21:31
@trwalke trwalke changed the title Enabling IdWeb to use ExtraBodyParameters Prototype Enabling IdWeb to use ExtraBodyParameters Aug 26, 2025
@trwalke trwalke mentioned this pull request Aug 26, 2025
Closed
jmprieur
jmprieur reviewed Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left a couple of suggestions. Will approve when we have aligned.

@bgavrilMS bgavrilMS merged commit 4b722ef into master Aug 27, 2025
5 checks passed
@bgavrilMS bgavrilMS deleted the trwalke/ExtraParameteAttributes branch August 27, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trwalke @bgavrilMS @jmprieur