Skip to content

Conversation

@gladjohn
Copy link
Contributor

@gladjohn gladjohn commented Feb 26, 2025

Fix for Remove NuGet Source steps (now with enhanced logging)

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fix -

  • The updated script checked if nuget.config exists before using it.
  • If it was missing, it used the global NuGet config instead.

This pull request includes changes to the build/template-restore-build-MSIdentityWeb.yaml file to improve the handling of NuGet sources in the build process. The key changes focus on adding checks for the existence of a nuget.config file, enhancing logging, and ensuring robust handling of NuGet source addition and removal.

Improvements to NuGet source handling:

  • Added a check for the existence of nuget.config and appropriate logging messages to inform whether the file was found or not.
  • Enhanced logging to list existing NuGet sources before making any changes, and to confirm the successful addition or removal of NuGet sources.
  • Implemented conditional logic to use nuget.config if it exists for adding and removing NuGet sources, ensuring the correct configuration file is used.
  • Added error handling to exit the script if the removal or addition of a NuGet source fails, ensuring the build process does not proceed with incorrect configurations.

Fixes #3264

@gladjohn gladjohn requested a review from a team as a code owner February 26, 2025 00:59
@gladjohn gladjohn changed the title Fix for Remove NuGet Source steps with enhanced logging Fix for Remove NuGet Source steps (now with enhanced logging) Feb 26, 2025
@gladjohn gladjohn merged commit f6c41a6 into master Feb 26, 2025
5 checks passed
@gladjohn gladjohn deleted the gladjohn-nuget-source branch February 26, 2025 01:12
@github-actions
Copy link

Summary

Summary
Generated on: 2/26/2025 - 1:12:45 AM
Coverage date: 2/26/2025 - 1:12:00 AM - 2/26/2025 - 1:12:42 AM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@pmaytak pmaytak added this to the 3.8.0 milestone Mar 21, 2025
This was referenced Aug 1, 2025
This was referenced Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Pipeline Fails Due to nuget.config in Microsoft Identity Web Repository

5 participants