FIC+OIDC credential provider #3255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
commented
Feb 25, 2025
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@bgavrilMS |
bgavrilMS
force-pushed
the
jmprieur/protoFicPlusOidc
branch
from
90ddea8 to
f91691d
Compare
SummarySummary
CoverageNo assemblies have been covered. |
- `GetValue(key, out IConfidentialClientApplication? application) && application != null)` was not right because if `TryGetValue` returns `false`, application will necessarilly be **null**. So the condition `!TryGetValue(...) && application != null` can never be true. - which implies that we'll have a race condition: `BuildConfidentialClientApplicationAsync to be executed multiple times concurrently for the same key. The pattern used here:` The propsed code with a semaphore per key released on all cases should prevents multiple concurrent builds while still allowing concurrent access to different applications.
Moves the xcloud fix code to a new assembly Fixes #3243 (Certr otation test bug due to SFI) Adds a TestOnly namespace to reset the TokenAcquirerFactory
bgavrilMS
approved these changes
Mar 3, 2025
Co-authored-by: Jean-Marc Prieur <[email protected]>
jennyf19
reviewed
Mar 3, 2025
...ests/OidcIdPSignedAssertionProviderTests/OidCIdPSignedAssertionProviderExtensibilityTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
approved these changes
Mar 3, 2025
…D/microsoft-identity-web into jmprieur/protoFicPlusOidc
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto for FIC+OIDC