Adding Extensibility for Custom Signed Assertion Providers#3226
Merged
JoshLozensky merged 37 commits intomasterfrom Feb 6, 2025
Merged
Adding Extensibility for Custom Signed Assertion Providers#3226JoshLozensky merged 37 commits intomasterfrom
JoshLozensky merged 37 commits intomasterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jmprieur
reviewed
Jan 30, 2025
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
Good start
I left some questions/comments. I'm puzzled by the exceptions.
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
…rCustomSignedAssertion.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com>
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
jmprieur
reviewed
Jan 30, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoaderCustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
I mistook "log a new error" from the spec for throw a new exception |
This comment was marked as resolved.
This comment was marked as resolved.
jmprieur
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/CertificateErrorMessage.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Let's have an aka.ms link for the error messages for this feature. |
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
jennyf19
reviewed
Feb 3, 2025
src/Microsoft.Identity.Web.Certificate/DefaultCredentialsLoader.CustomSignedAssertion.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 3, 2025
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
…omSignedAssertionProvider
This was referenced Dec 5, 2025
This was referenced Dec 13, 2025
This was referenced Jan 7, 2026
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extensibility for customers to be able to define their own signed assertion providers. The integration test in \tests\E2E Tests\CustomSignedAssertionProviderTests\CustomSignedAssertionProviderExtensibilityTests.cs has an example of the sort of work a customer would need to do in order to use this functionality.
Fixes #3220