Implements GetAuthorizationHeaderAsync to support 1P specific scenarios#2896
Merged
Implements GetAuthorizationHeaderAsync to support 1P specific scenarios#2896
Conversation
sruke
commented
Jun 14, 2024
sruke
commented
Jun 14, 2024
src/Microsoft.Identity.Web.GraphServiceClient/GraphAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jun 17, 2024
jennyf19
reviewed
Jun 17, 2024
jmprieur
reviewed
Jun 19, 2024
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
This looks good.
did you run the test apps, in particular the Web App Calls Graph (there are links on the index page)
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Show resolved
Hide resolved
added 2 commits
June 21, 2024 10:29
Contributor
Author
Yes, all the ID.Web tests are passing including WebAppCallsApiCallsGraph test. |
sruke
changed the title
jennyf19
approved these changes
Jun 24, 2024
Collaborator
jennyf19
left a comment
jennyf19
left a comment
There was a problem hiding this comment.
we want this in master as well, correct?
jmprieur
approved these changes
Jun 24, 2024
Contributor
Author
Yes. Once this PR is merged, I'll cherry pick this change into master. |
sruke
added a commit
that referenced
this pull request
Jun 24, 2024
…os (#2896) * Implements IAuthorizationHeaderProviderExtension * Use DownstreamApiOptions.RequestAppToken to check if header is for app or user * Updates Abstractions version * Updates CAE tests --------- Co-authored-by: Sruthi Keerthi Rangavajhula (from Dev Box) <[email protected]>
Merged
sruke
added a commit
that referenced
this pull request
Jun 25, 2024
* Implements GetAuthorizationHeaderAsync to support 1P specific scenarios (#2896) * Implements IAuthorizationHeaderProviderExtension * Use DownstreamApiOptions.RequestAppToken to check if header is for app or user * Updates Abstractions version * Updates CAE tests --------- Co-authored-by: Sruthi Keerthi Rangavajhula (from Dev Box) <[email protected]> * Add missing using * Update test --------- Co-authored-by: Sruthi Keerthi Rangavajhula (from Dev Box) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
This is being done to accommodate 1P specific protocols.