Addition of environment variables as config source in TokenAcquirerFactory #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Sep 28, 2023
Collaborator
jmprieur
left a comment
jmprieur
left a comment
There was a problem hiding this comment.
LGTM
Thanks for this addition, @markjritchie
jmprieur
changed the title
jennyf19
approved these changes
Sep 28, 2023
|
When can we expect this to be released? |
Collaborator
|
@simonschlegel, @markjritchie :we intend to release 2.15.0 tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of environment variables as config source
Description
Addition of environment variables as a source for configuration values. Placed after appsettings.config so that they can be used to override variables. Especially useful in containers.
Fixes #2480