Conditionally target net 8 #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
reviewed
Jul 5, 2023
jennyf19
reviewed
Jul 5, 2023
jennyf19
reviewed
Jul 5, 2023
jennyf19
reviewed
Jul 5, 2023
...soft.Identity.Web/WebAppExtensions/MicrosoftIdentityWebAppAuthenticationBuilderExtensions.cs
Show resolved
Hide resolved
westin-m
force-pushed
the
westinm/net8preview
branch
from
683de09 to
91a1a80
Compare
Collaborator
|
can we get .net 8 added here as well to the github action? https://github.com/AzureAD/microsoft-identity-web/blob/master/.github/workflows/dotnetcore.yml |
westin-m
force-pushed
the
westinm/net8preview
branch
from
91a1a80 to
816decb
Compare
westin-m
force-pushed
the
westinm/net8preview
branch
3 times, most recently
from
a61e65e to
f91d42d
Compare
jmprieur
reviewed
Jul 7, 2023
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
westin-m
force-pushed
the
westinm/net8preview
branch
from
f91d42d to
e6026bc
Compare
jmprieur
reviewed
Jul 10, 2023
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationHandler.cs
Show resolved
Hide resolved
jmprieur
reviewed
Jul 10, 2023
...soft.Identity.Web/WebAppExtensions/MicrosoftIdentityWebAppAuthenticationBuilderExtensions.cs
Show resolved
Hide resolved
westin-m
force-pushed
the
westinm/net8preview
branch
from
ff544a7 to
d85cb5d
Compare
jmprieur
reviewed
Jul 11, 2023
westin-m
force-pushed
the
westinm/net8preview
branch
5 times, most recently
from
6a9ff63 to
6bcb87f
Compare
westin-m
force-pushed
the
westinm/net8preview
branch
from
6bcb87f to
221e05d
Compare
jennyf19
reviewed
Jul 17, 2023
jennyf19
reviewed
Jul 17, 2023
jennyf19
reviewed
Jul 17, 2023
jmprieur
approved these changes
Jul 17, 2023
jennyf19
requested changes
Jul 17, 2023
Collaborator
jennyf19
left a comment
jennyf19
left a comment
There was a problem hiding this comment.
would like to update to use preview 6
westin-m
force-pushed
the
westinm/net8preview
branch
from
266b7ec to
94e3a73
Compare
jennyf19
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a net 8 target to Id Web with conditional compilation.