fixed race condition between signin button click and navigation in B2C e2e test #8098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the B2C e2e test where the sign-in button click and navigation were not properly synchronized, and updates the client secret environment variable name to match Azure conventions.
- Fixed race condition by properly waiting for navigation after sign-in button click
- Updated environment variable name from CLIENT_SECRET to AZURE_CLIENT_SECRET
- Improved code formatting for the screenshot folder path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| samples/msal-node-samples/b2c-user-flows/test/user-flows-local.spec.ts | Fixed race condition with Promise.all navigation wait and improved formatting |
| samples/msal-node-samples/b2c-user-flows/README.md | Updated environment variable name to AZURE_CLIENT_SECRET |
peterzenz
approved these changes
Oct 14, 2025
lalimasharda
changed the title
hectormmg
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.