Fix iframe fallback when RT is not found in cache #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
hectormmg,
jo-arroyo,
konstantin-msft,
peterzenz and
sameerag
as code owners
tnorling
commented
Oct 23, 2023
| )(silentRequest) | ||
| .then((result) => result as AuthenticationResult) | ||
| .then((result: AuthenticationResult) => { | ||
| this.performanceClient.addFields( |
Collaborator
Author
There was a problem hiding this comment.
These things are added at the top level API
Codecov Report
|
peterzenz
approved these changes
Oct 23, 2023
lalimasharda
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this fallback behavior was missed in the transition from v2 to v3. When the RT cannot be found in the cache we should try to fallback to the iframe flow. Also includes minor refactor to make the code more readable and remove some unnecessary work.