Dependency cleanup #951
Merged
Dependency cleanup #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
approved these changes
May 8, 2025
|
|
||
| <build> | ||
| <sourceDirectory>${project.build.directory}/delombok</sourceDirectory> | ||
| <sourceDirectory>src/main/java</sourceDirectory> |
There was a problem hiding this comment.
nit: leaving this is probably fine but I would expect that to be the default value.
| .get(); | ||
| } | ||
|
|
||
| public void acquireTokensInHomeAndGuestClouds(String homeCloud) throws MalformedURLException { |
There was a problem hiding this comment.
Surprised to just see a whole test getting removed - what's up?
Contributor
Author
There was a problem hiding this comment.
It wasn't a whole test, it was a helper for some tests (like the similarly named "acquireTokenInteractive" and "acquireTokenInteractive_instanceAware")
However, it it seems like other changes and refactoring over the years got rid of all usages of it and it must've been missed by whatever got rid of the last reference.
bgavrilMS
approved these changes
May 12, 2025
And config for pipeline task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final dependency changes in test classes, and cleanup of various unused methods/fields/imports/dependencies, to finish the work in #909
Except for
pom.xml, the changes were made only in test classes. The actual behavior and coverage of those tests are the same as before, and the changes mainly affect classes that get test resources from the labs API plus a few small adjustments to use the new dependencies appropriately.The PR makes the following changes:
CachePersistenceIT,Config,App,Lab,LabService,User,UserSecret,CacheFormatTestspom.xml