Update the logic to add file based detection for azure arc for linux env #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 24, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 24, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jul 24, 2024
gladjohn
reviewed
Jul 24, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AzureArcManagedIdentitySource.cs
Show resolved
Hide resolved
trwalke
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 5, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 5, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Aug 5, 2024
…om/AzureAD/microsoft-authentication-library-for-dotnet into nebharg/AzureArcFilebasedDetection
…om/AzureAD/microsoft-authentication-library-for-dotnet into nebharg/AzureArcFilebasedDetection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4358
Changes proposed in this request
Add file based detection in addition to env variables when env variables are not found.
Testing
Performance impact
Documentation