Skip to content

Update Telemetry client with data outlined in spec #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
May 23, 2023
Merged

Update Telemetry client with data outlined in spec #3737

merged 38 commits into from
May 23, 2023

Conversation

@neha-bhargava
Copy link
Contributor

@neha-bhargava neha-bhargava commented Oct 6, 2022 •
edited by pmaytak
Loading

Fixes #3596, fixes #4119.

Changes proposed in this request

  • Add a placeholder for datapoints in TokenCacheNotificationArgs. These values will be populated when cache access is done in Microsoft.Identity.Web.
  • Log the data points to telemetry pipeline.

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

@neha-bhargava neha-bhargava marked this pull request as ready for review October 6, 2022 21:40
@neha-bhargava neha-bhargava mentioned this pull request Oct 6, 2022
Closed
bgavrilMS
bgavrilMS reviewed Oct 7, 2022
View reviewed changes
bgavrilMS
bgavrilMS reviewed Oct 7, 2022
View reviewed changes
bgavrilMS
bgavrilMS requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is only blocking change, code looks ok otherwise with minor changes suggested.

@neha-bhargava
Copy link
Contributor Author

neha-bhargava commented Oct 15, 2022

Removed the CacheUsed variable as this can be inferred as:

if (L2Latency > 0) 
    CacheUsed = L2
else 
    CacheUsed = L1

@pmaytak pmaytak self-requested a review October 26, 2022 05:25
pmaytak
pmaytak reviewed Oct 27, 2022
View reviewed changes
@trwalke trwalke requested review from bgavrilMS, gladjohn and pmaytak May 3, 2023 21:48
@trwalke
Copy link
Member

trwalke commented May 3, 2023

cc @neha-bhargava for one final look

bgavrilMS
bgavrilMS approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

@neha-bhargava - can you please also show Travis how you tested this E2E so that we can see some values in Kusto ? Some manual validation would be great.

@bgavrilMS
Copy link
Member

bgavrilMS commented May 10, 2023

@trwalke - please create a work item on ID.Web to track the work in the cache project.

pmaytak
pmaytak reviewed May 12, 2023
View reviewed changes
trwalke and others added 2 commits May 16, 2023 01:03
@trwalke trwalke mentioned this pull request May 17, 2023
Closed
Merge branch 'main' into nebharg/AddCacheDetailsTelemetry
657a8cc 
# Conflicts:
#	tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/PoPTests.cs
#	tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs
@trwalke trwalke enabled auto-merge (squash) May 23, 2023 05:41
@trwalke trwalke merged commit c99a106 into main May 23, 2023
@trwalke trwalke deleted the nebharg/AddCacheDetailsTelemetry branch May 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trwalke trwalke trwalke left review comments

@pmaytak pmaytak pmaytak approved these changes

@TimHannMSFT TimHannMSFT TimHannMSFT left review comments

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@gladjohn gladjohn Awaiting requested review from gladjohn

+1 more reviewer

@rymeskar rymeskar rymeskar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

8 participants

@neha-bhargava @TimHannMSFT @trwalke @bgavrilMS @rymeskar @pmaytak @gladjohn