Skip to content

Update package inspector to generate SHA-512 along with SHA-1 #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025
Merged

Update package inspector to generate SHA-512 along with SHA-1 #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2ea0c6
Refactor signing certificate hash generation to include SHA-512 and u…
p3dr0rv Jul 1, 2025
0da3b1d
Update package-inspector/src/main/java/com/microsoft/inspector/MainAc…
p3dr0rv Jul 1, 2025
99433aa
Update package-inspector/src/main/java/com/microsoft/inspector/MainAc…
p3dr0rv Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions msal/src/main/java/com/microsoft/identity/client/PublicClientApplicationConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,8 +772,7 @@ private boolean isValidAuthenticatorRedirectUri() {
if (AuthenticationConstants.Broker.AZURE_AUTHENTICATOR_APP_RELEASE_SIGNATURE_SHA512.equalsIgnoreCase(sha512_signingCertThumbprint)
|| AuthenticationConstants.Broker.AZURE_AUTHENTICATOR_APP_DEBUG_SIGNATURE_SHA512.equalsIgnoreCase(sha512_signingCertThumbprint)) {

// MSAL still uses SHA-1 format in redirect url.
final MessageDigest md_sha1 = MessageDigest.getInstance("SHA");
final MessageDigest md_sha1 = MessageDigest.getInstance("SHA"); // CodeQL [SM05136] MSAL still uses SHA-1 format in redirect url.
md_sha1.update(signature.toByteArray());
final String sha1_signingCertThumbprint = Base64.encodeToString(md_sha1.digest(), Base64.NO_WRAP);

Expand Down
16 changes: 11 additions & 5 deletions package-inspector/src/main/java/com/microsoft/inspector/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,18 +139,24 @@ public void onItemClick(AdapterView<?> adapterView, View view, int position, lon
getPackageManagerFlag()
);

String packageSigningSha = "";
String signingCertificateHashes = "";

final Signature[] signatures = getSignatures(packageInfo);
if (null != signatures
&& signatures.length > 0) {
final Signature signature = signatures[0];
final MessageDigest digest = MessageDigest.getInstance("SHA");
digest.update(signature.toByteArray());
packageSigningSha = Base64.encodeToString(digest.digest(), Base64.NO_WRAP);
final MessageDigest digestSha1 = MessageDigest.getInstance("SHA-1"); // CodeQL [SM05136] This is only for test purposes, not used in production.
digestSha1.update(signature.toByteArray());
final String packageSigningSha1 = Base64.encodeToString(digestSha1.digest(), Base64.NO_WRAP);

final MessageDigest digestSha512 = MessageDigest.getInstance("SHA-512");
digestSha512.update(signature.toByteArray());
final String packageSigningSha512 = Base64.encodeToString(digestSha512.digest(), Base64.NO_WRAP);

signingCertificateHashes = "SHA-1: " + packageSigningSha1 + "\nSHA-512: " + packageSigningSha512;
}

String msg = packageSigningSha;
String msg = signingCertificateHashes;

if (isAnAuthenticatorApp(pkgName)) {
msg += "\n\n" + getAuthenticatorAppMetadata(pkgName);
Expand Down