Native auth: JIT business logic #2290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
nilo-ms
commented
May 1, 2025
.../src/main/java/com/microsoft/identity/nativeauth/utils/NativeAuthCommandParametersAdapter.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces just-in-time (JIT) business logic for native authentication by updating state machine flows and integrating new result types. Key changes include:
- Adding support for StrongAuthMethodRegistrationRequired in SignInStates and NativeAuthPublicClientApplication.
- Introducing BaseJITSubmitChallengeState and refactoring RegisterStrongAuthState and RegisterStrongAuthVerificationRequiredState to handle JIT challenge flows.
- Modifying API visibility in CommandParametersAdapter.java to expose getPackageVersion for potential external usage.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/SignInStates.kt | Added new branch handling for StrongAuthMethodRegistrationRequired state. |
| msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/JITStates.kt | Introduced BaseJITSubmitChallengeState and refactored JIT related state classes to support challenge submission flows. |
| msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/results/SignInResult.kt | Updated new StrongAuthMethodRegistrationRequired result type with authMethods. |
| msal/src/main/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplication.kt | Added logic to handle the new StrongAuthMethodRegistrationRequired branch. |
| msal/src/main/java/com/microsoft/identity/client/internal/CommandParametersAdapter.java | Changed getPackageVersion visibility from private to public. |
Comments suppressed due to low confidence (1)
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/RegisterStrongAuthState.kt:182
- [nitpick] If the 'scopes' field is no longer used, remove the commented-out code and associated parcel read/write operations for clarity.
scopes = parcel.createStringArrayList(),
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/JITStates.kt
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/client/internal/CommandParametersAdapter.java
Outdated
Show resolved
Hide resolved
Yuki-YuXin
reviewed
May 2, 2025
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/JITStates.kt
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/JITStates.kt
Outdated
Show resolved
Hide resolved
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/states/SignInStates.kt
Show resolved
Hide resolved
Yuki-YuXin
reviewed
May 8, 2025
| * @param grantType grant type | ||
| * @param code the code provided by the user | ||
| * @param correlationId correlation ID to use in the API request, taken from the previous request in the flow | ||
| * @param continuationToken Continuation token |
Yuki-YuXin
approved these changes
May 8, 2025
nilo-ms
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
May 8, 2025
Last PR to complete JIT feature. This PR is in draft because tests are missing. You can review it in the meantime. MSAL PR: [#2290](AzureAD/microsoft-authentication-library-for-android#2290) [AB#3188136](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3188136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR to complete JIT feature.
This PR is in draft because tests are missing. You can review it in the meantime.
Common code PR: #2637
AB#3188136