Skip to content

Use in-memory cache for accounts and credentials FixesAB#3417272, Fixes AB#3417272 #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddhijain merged 8 commits into from
Nov 13, 2025
Merged

Use in-memory cache for accounts and credentials FixesAB#3417272, Fixes AB#3417272 #2802

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b2ae23
Use in-memory cache for accounts and credentials
siddhijain Nov 4, 2025
b9a26f6
Update changelog for Broker implementation change
siddhijain Nov 4, 2025
00da88b
Added telemetry to see if in-memory cache was used
siddhijain Nov 4, 2025
8b06ea2
Merge branch 'dev' into sjain/use-in-memory-cache-for-accounts-and-cr…
siddhijain Nov 10, 2025
46213ab
Move the logic from MsalCache to BrokerCache
siddhijain Nov 10, 2025
5addf56
Removing unused imports
siddhijain Nov 10, 2025
9431133
Merge branch 'dev' into sjain/use-in-memory-cache-for-accounts-and-cr…
siddhijain Nov 11, 2025
381a40c
Removed unintentional change + add unit tests
siddhijain Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
vNext
----------
- [MINOR] Use SharedPreferencesInMemoryCache implementation in Broker (#2802)
- [MINOR] Add new span name for DELEGATION_CERT_INSTALL's telemetry (#2790)
- [MINOR] Refactor getAccountByLocalAccountId (#2781)
- [MINOR] Add OTel Benchmarker (#2786)
Expand Down Expand Up @@ -1189,4 +1190,4 @@ Version 0.0.3
* Separate methods for PII/OII logging
- Initial Exception model implemented
* BaseException + Client & Service subclasses
- Substantial portions of HTTP/S networking code migrated from ADAL & MSAL to this module
- Substantial portions of HTTP/S networking code migrated from ADAL & MSAL to this module
6 changes: 5 additions & 1 deletion common4j/src/main/com/microsoft/identity/common/java/cache/MsalOAuth2TokenCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
import com.microsoft.identity.common.java.dto.IdTokenRecord;
import com.microsoft.identity.common.java.dto.RefreshTokenRecord;
import com.microsoft.identity.common.java.exception.ClientException;
import com.microsoft.identity.common.java.flighting.CommonFlight;
import com.microsoft.identity.common.java.flighting.CommonFlightsManager;
import com.microsoft.identity.common.java.interfaces.INameValueStorage;
import com.microsoft.identity.common.java.interfaces.IPlatformComponents;
import com.microsoft.identity.common.java.logging.Logger;
Expand Down Expand Up @@ -161,7 +163,9 @@ MicrosoftRefreshToken> create(@NonNull final IPlatformComponents components, boo
String.class
);
final IAccountCredentialCache accountCredentialCache;
if (useInMemoryCache) {
if (useInMemoryCache || CommonFlightsManager.INSTANCE
.getFlightsProvider()
.isFlightEnabled(CommonFlight.USE_IN_MEMORY_CACHE_FOR_ACCOUNTS_AND_CREDENTIALS)) {
accountCredentialCache = new SharedPreferencesAccountCredentialCacheWithMemoryCache(
cacheKeyValueDelegate,
sharedPreferencesFileManager
Expand Down
7 changes: 6 additions & 1 deletion common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,12 @@ public enum CommonFlight implements IFlightConfig {
* Flight to enable OpenID issuer validation code which validates issuer against the open id well known
* config endpoint and only reports the failure result.
*/
ENABLE_OPENID_ISSUER_VALIDATION_REPORTING("EnableOpenIdIssuerValidationReporting", true);
ENABLE_OPENID_ISSUER_VALIDATION_REPORTING("EnableOpenIdIssuerValidationReporting", true),

/**
* Flight to control whether or not to use in memory cache for accounts and credentials.
*/
USE_IN_MEMORY_CACHE_FOR_ACCOUNTS_AND_CREDENTIALS("UseInMemoryCacheForAccountsAndCredentials", false);

private String key;
private Object defaultValue;
Expand Down
Loading