partial revert to fix failing tests in broker FixesAB#3397557, Fixes AB#3397557 #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhijain
added
the
No-Changelog
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR partially reverts a previous commit to fix failing tests related to null environment handling in the broker's account lookup logic. The revert addresses cases where the environment parameter can be null when calling get_account_by_local_account_id.
Key Changes:
- Removed environment comparison from
getAccountByLocalAccountIdmethod to handle null environment cases - Restored environment checking in
accountHasCredentialmethod to maintain credential validation integrity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
common4j/src/main/com/microsoft/identity/common/java/cache/MsalOAuth2TokenCache.java
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/cache/MsalOAuth2TokenCache.java
Show resolved
Hide resolved
github-actions
bot
changed the title
andwhysoft
approved these changes
Oct 28, 2025
cacosta33
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixesAB#3397557
Recently refactored getAccountByLocalAccountId method to first filter both accounts and credentials on environment and then, check their homeAccountId to match the accounts with credentials. However, that refactoring does not work when environment passed is null. This resulted in test failures in the broker repo. #2781
This PR is to revert some of the changes made as part of that commit and fix the failing tests.