Skip to content

Conversation

@somalaya
Copy link
Contributor

@somalaya somalaya commented Jul 31, 2025

  • Removed the tenantId list and making use of tenant based flighting for webcp
  • Added another flight to control the timeout value used for fetching the webcp flight. default value is 3secs.

Related broker PR : https://github.com/AzureAD/ad-accounts-for-android/pull/3175

Fixes AB#3335954

Copilot AI review requested due to automatic review settings July 31, 2025 03:24
@somalaya somalaya requested a review from a team as a code owner July 31, 2025 03:24
@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the tenant ID list-based approach for WebCP feature enablement with tenant-based flighting, improving the flexibility and control of feature rollouts. The change moves from checking if a tenant ID exists in a static list to using the tenant-specific flight provider with configurable timeout.

Key changes:

  • Removed hardcoded tenant ID list logic and replaced with tenant-based flight checking
  • Added configurable timeout for WebCP flight retrieval with a default of 3 seconds
  • Enhanced telemetry to track flight check performance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
AttributeName.java Added new telemetry attribute to track WebCP flight check duration
CommonFlight.java Added new flight configuration for WebCP timeout control
AzureActiveDirectoryWebViewClient.java Replaced tenant list logic with tenant-based flight provider and added performance tracking

@somalaya somalaya force-pushed the somalaya/webcpFlightChange branch from 97b0614 to a675ee1 Compare July 31, 2025 03:37
@somalaya somalaya requested a review from a team as a code owner July 31, 2025 03:37
@mohitc1
Copy link
Contributor

mohitc1 commented Jul 31, 2025

TENANT_LIST_TO_ENABLE_WEB_CP_IN_WEBVIEW("TenantListToEnableWebCpInWebView", ""),

Delete this?


Refers to: common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java:142 in a675ee1. [](commit_id = a675ee1, deletion_comment = False)

Copy link
Contributor

@mohitc1 mohitc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@somalaya somalaya changed the title Using tenant based flighting for webcp Using tenant based flighting for webcp, Fixes AB#3335954 Jul 31, 2025
@github-actions
Copy link

✅ Work item link check complete. Description contains link AB#3335954 to an Azure Boards work item.

@somalaya somalaya force-pushed the somalaya/webcpFlightChange branch from c00c231 to 6abea9d Compare July 31, 2025 21:16
@somalaya somalaya merged commit 3b1aa77 into dev Jul 31, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants