-
Notifications
You must be signed in to change notification settings - Fork 46
Using tenant based flighting for webcp, Fixes AB#3335954 #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the tenant ID list-based approach for WebCP feature enablement with tenant-based flighting, improving the flexibility and control of feature rollouts. The change moves from checking if a tenant ID exists in a static list to using the tenant-specific flight provider with configurable timeout.
Key changes:
- Removed hardcoded tenant ID list logic and replaced with tenant-based flight checking
- Added configurable timeout for WebCP flight retrieval with a default of 3 seconds
- Enhanced telemetry to track flight check performance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AttributeName.java | Added new telemetry attribute to track WebCP flight check duration |
| CommonFlight.java | Added new flight configuration for WebCP timeout control |
| AzureActiveDirectoryWebViewClient.java | Replaced tenant list logic with tenant-based flight provider and added performance tracking |
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Outdated
Show resolved
Hide resolved
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Show resolved
Hide resolved
97b0614 to
a675ee1
Compare
...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java
Show resolved
Hide resolved
mohitc1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
✅ Work item link check complete. Description contains link AB#3335954 to an Azure Boards work item. |
c00c231 to
6abea9d
Compare
Related broker PR : https://github.com/AzureAD/ad-accounts-for-android/pull/3175
Fixes AB#3335954