-
Notifications
You must be signed in to change notification settings - Fork 46
changes accommodating the WrappedKeyAlgoIdentifier module, Fixes AB#3297251 #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces changes to accommodate the WrappedKeyAlgoIdentifier module by adding a new enum constant in the SpanName class and a corresponding exception error code in the ClientException class.
- Added new enum member "WrappedKeyAlgorithmIdentifier" in SpanName.java
- Added new client exception constant "DEVICE_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT" in ClientException.java
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java | Added enum constant for the WrappedKeyAlgoIdentifier module |
| common4j/src/main/com/microsoft/identity/common/java/exception/ClientException.java | Added new exception constant for hardware wrapped key import support |
Comments suppressed due to low confidence (2)
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java:67
- [nitpick] Consider verifying the naming consistency with the module reference. If the module is referred to as 'WrappedKeyAlgoIdentifier', it might be more consistent to use the same abbreviation or update the module reference accordingly.
WrappedKeyAlgorithmIdentifier
common4j/src/main/com/microsoft/identity/common/java/exception/ClientException.java:502
- [nitpick] Consider revising the constant name for improved clarity and grammatical correctness; for example, 'DEVICE_DOES_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT' could better convey the intended meaning.
public static final String DEVICE_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT = "device_not_supported_hardware_wrapped_key_import";
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3297251 to an Azure Boards work item. |
mohitc1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
AB#3297251