Skip to content

Conversation

@rpdome
Copy link
Member

@rpdome rpdome commented Jun 12, 2025

Copilot AI review requested due to automatic review settings June 12, 2025 00:55
@rpdome rpdome requested a review from a team as a code owner June 12, 2025 00:55
@rpdome rpdome added the No-Changelog This Pull-Request has no associated changelog entry. label Jun 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces changes to accommodate the WrappedKeyAlgoIdentifier module by adding a new enum constant in the SpanName class and a corresponding exception error code in the ClientException class.

  • Added new enum member "WrappedKeyAlgorithmIdentifier" in SpanName.java
  • Added new client exception constant "DEVICE_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT" in ClientException.java

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java Added enum constant for the WrappedKeyAlgoIdentifier module
common4j/src/main/com/microsoft/identity/common/java/exception/ClientException.java Added new exception constant for hardware wrapped key import support
Comments suppressed due to low confidence (2)

common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java:67

  • [nitpick] Consider verifying the naming consistency with the module reference. If the module is referred to as 'WrappedKeyAlgoIdentifier', it might be more consistent to use the same abbreviation or update the module reference accordingly.
WrappedKeyAlgorithmIdentifier

common4j/src/main/com/microsoft/identity/common/java/exception/ClientException.java:502

  • [nitpick] Consider revising the constant name for improved clarity and grammatical correctness; for example, 'DEVICE_DOES_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT' could better convey the intended meaning.
public static final String DEVICE_NOT_SUPPORT_HARDWARE_WRAPPED_KEY_IMPORT = "device_not_supported_hardware_wrapped_key_import";

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions
Copy link

✅ Work item link check complete. Description contains link AB#3297251 to an Azure Boards work item.

@github-actions github-actions bot changed the title changes accommodating the WrappedKeyAlgoIdentifier module changes accommodating the WrappedKeyAlgoIdentifier module, Fixes AB#3297251 Jun 12, 2025
@rpdome rpdome requested a review from a team as a code owner June 12, 2025 01:01
Copy link
Contributor

@mohitc1 mohitc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rpdome rpdome merged commit bf84a1e into dev Jun 13, 2025
23 of 25 checks passed
@rpdome rpdome deleted the rapong/wrapperAlgo branch June 13, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants