Native auth: network layer for JIT feature, Fixes AB#3188135 #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse value for verification required
github-actions
bot
changed the title
Yuki-YuXin
reviewed
Apr 15, 2025
...rc/main/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthResponseHandler.kt
Show resolved
Hide resolved
Yuki-YuXin
approved these changes
Apr 16, 2025
spetrescu84
reviewed
Apr 16, 2025
.../com/microsoft/identity/common/java/nativeauth/providers/requests/jit/JITChallengeRequest.kt
Outdated
Show resolved
Hide resolved
.../com/microsoft/identity/common/java/nativeauth/providers/requests/jit/JITChallengeRequest.kt
Outdated
Show resolved
Hide resolved
...n/com/microsoft/identity/common/java/nativeauth/providers/requests/jit/JITContinueRequest.kt
Outdated
Show resolved
Hide resolved
...n/com/microsoft/identity/common/java/nativeauth/providers/requests/jit/JITContinueRequest.kt
Outdated
Show resolved
Hide resolved
...com/microsoft/identity/common/java/nativeauth/providers/requests/jit/JITIntrospectRequest.kt
Show resolved
Hide resolved
...est/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthRequestProviderTest.kt
Show resolved
Hide resolved
...est/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthResponseHandlerTest.kt
Outdated
Show resolved
Hide resolved
...est/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthResponseHandlerTest.kt
Show resolved
Hide resolved
...est/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthResponseHandlerTest.kt
Outdated
Show resolved
Hide resolved
...est/com/microsoft/identity/common/java/nativeauth/providers/NativeAuthResponseHandlerTest.kt
Show resolved
Hide resolved
spetrescu84
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding network layer for JIT feature. Integration tests are written for the NativeAuthOAuth2Strategy class. To write tests for this class, I need to create new commandParameters classes. Since these classes are more related to the business logic, I decided to add them and the integration tests in the next PR.
AB#3188135