Expose a JavaScript API in brokered Webviews to facilitate Improved Same Device NumberMatch , Fixes AB#3203956 #2617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3203956 to an Azure Boards work item. |
1 similar comment
|
✅ Work item link check complete. Description contains link AB#3203956 to an Azure Boards work item. |
github-actions
bot
changed the title
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 2, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Apr 11, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
somalaya
approved these changes
Apr 11, 2025
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 15, 2025
...in/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchJavaScriptInterface.kt
Show resolved
Hide resolved
shahzaibj
reviewed
May 16, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 16, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 16, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 16, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObject.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObject.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObject.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObject.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
| // Call the method | ||
| authUxJavaScriptInterface.postMessageToBroker("NotAJson") | ||
|
|
||
| // Should not get an exception |
Contributor
There was a problem hiding this comment.
Can we also validate that message was actually posted?
Contributor
Author
There was a problem hiding this comment.
What can be done to validate this? Copilot seems to want to validate the log statement, but can't get it to work
shahzaibj
reviewed
May 20, 2025
...n/src/test/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObjectTest.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 20, 2025
...n/src/test/java/com/microsoft/identity/common/internal/broker/AuthUxJsonPayloadObjectTest.kt
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 22, 2025
common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java
Outdated
Show resolved
Hide resolved
shahzaibj
reviewed
May 22, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJavaScriptInterface.kt
Outdated
Show resolved
Hide resolved
shahzaibj
approved these changes
May 24, 2025
shahzaibj
approved these changes
May 24, 2025
fadidurah
added a commit
that referenced
this pull request
May 30, 2025
…956, Closed AB#3203956 (#2653) Minor change was made to the json schema, updated our code to match. Also put JavaScript API behind a flight. New schema: { "correlationID": "$UUID" "action_name":"write_data", "action_component":"broker", "params": { "operation": "number_matching", "sessionID": "$sessionID", "code_match": "$number" } } Original numberMatch PR: #2617 [AB#3203956](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3203956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPEC: https://microsoft-my.sharepoint-df.com/:w:/r/personal/siddhijain_microsoft_com/_layouts/15/Doc.aspx?sourcedoc=%7BD1D944D5-2047-40AB-B8F9-98506BF212A3%7D&file=Engineering%20design%20-%20Number%20matching%20on%20same%20device.docx&action=default&mobileredirect=true&share=IQHVRNnRRyCrQLj5mFBr8hKjAbj81fEnpO6X-99laqs2j_M&wdOrigin=TEAMS-MAGLEV.p2p_ns.rwc&wdExp=TEAMS-TREATMENT&wdhostclicktime=1743094076241&web=1
Word Doc: for JavaScript Api: https://microsoft-my.sharepoint-df.com/:w:/p/veenasoman/EY1AZIeT8X5KrXVz97Vx520B3Jj0fBLSPlklnoRvcmbh0Q?e=ZVVUrw&nav=eyJoIjoiMjEzMzE1Mzg5NSJ9
Structure has changed a bit for this. To facilitate future work, we will have a generalized JavaScript API that takes in a json string payload. This is used to parse out a function name, and data field, both of which are used to call a specific function in broker code. This same functionality will be used next month for CA Block improvment work (I don't have a spec to this one yet).
Expected method call in JavaScript is now something like this, we are working on finalizing json schema:
BrokerJS.postToBroker('{function: NUMBER_MATCH,data: {sessionID: id, numberMatch: number}}')I added some unit tests in the broker PR, but primary validation will be when ests exposes a test slice that calls the JavaScript API. Did some testing in our webview class to call javascript code, and was able to prompt the numberMatch method.
Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3073
AB#3203956