Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,15 @@ interface INativeAuthCommandResult {
open val correlationId: String = DiagnosticContext.INSTANCE.threadCorrelationId,
open val errorCodes: List<Int>? = null
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're checking for blank usernames in the SDK interface, then we can remove the ArgUtils.validateNonNullArg(username, "username") from the respective request classes right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

data class InvalidUsername(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this class returned? I'm not seeing updates to the Controller or anywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

override val error: String?,
override val errorDescription: String?,
override val details: List<Map<String, String>>? = null,
override val correlationId: String,
override val errorCodes: List<Int>? = null,
val exception: Exception? = null
) : Error(error, errorDescription, details, correlationId, errorCodes),
INativeAuthCommandResult, SignInStartCommandResult, SignUpStartCommandResult, ResetPasswordStartCommandResult

}