Skip to content

Suppress CodeQL issue; no fix needed since ADAL is deprecated. #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Suppress CodeQL issue; no fix needed since ADAL is deprecated. #1825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db05133
Add deprecation notice for ADAL in unwrap method
p3dr0rv Jul 7, 2025
ee698ad
Add deprecation notice for ADAL in wrap method
p3dr0rv Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adal/src/main/java/com/microsoft/aad/adal/StorageHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,15 +670,15 @@ private synchronized void resetKeyPairFromAndroidKeyStore() throws KeyStoreExcep
@SuppressLint("GetInstance")
private byte[] wrap(final SecretKey key) throws GeneralSecurityException {
Logger.v(TAG, "Wrap secret key.");
final Cipher wrapCipher = Cipher.getInstance(WRAP_ALGORITHM);
final Cipher wrapCipher = Cipher.getInstance(WRAP_ALGORITHM); // CodeQL [SM05136] ADAL is deprecated, no more updates will be made.
wrapCipher.init(Cipher.WRAP_MODE, mKeyPair.getPublic());
return wrapCipher.wrap(key);
}

@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
@SuppressLint("GetInstance")
private SecretKey unwrap(final byte[] keyBlob) throws GeneralSecurityException {
final Cipher wrapCipher = Cipher.getInstance(WRAP_ALGORITHM);
final Cipher wrapCipher = Cipher.getInstance(WRAP_ALGORITHM); // CodeQL [SM05136] ADAL is deprecated, no more updates will be made.
wrapCipher.init(Cipher.UNWRAP_MODE, mKeyPair.getPrivate());
try {
return (SecretKey) wrapCipher.unwrap(keyBlob, KEYSPEC_ALGORITHM, Cipher.SECRET_KEY);
Expand Down
Loading