Switch to back to ValidationResult for results when validating a token.#3299
Merged
Switch to back to ValidationResult for results when validating a token.#3299
Conversation
Remove dependency on Microsoft.Identity.Abstractions
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
Contributor
|
For reference, 8.13.0 diff: 8.13.0...brentsch/ValidationResult |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR returns to using ValidationResult defined in IdentityModel instead of OperationResult from Microsoft.Identity.Abstractions. This resolves assembly version compatibility issues when different 8.x assemblies have varying versions and removes the dependency on Microsoft.Identity.Abstractions.
Key Changes:
- Replace all
OperationResult<TResult, TError>usages withValidationResult<TResult, TError> - Remove dependency on Microsoft.Identity.Abstractions package
- Update all validation method signatures and implementations throughout the codebase
- Remove using statements for Microsoft.Identity.Abstractions
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Multiple test files | Updated test method signatures and variable names from OperationResult to ValidationResult |
| ValidationResult.cs | New implementation of ValidationResult replacing OperationResult dependency |
| ValidationError.cs | Removed inheritance from OperationError |
| Multiple validator files | Updated method signatures and return types to use ValidationResult |
| Multiple handler files | Updated validation method signatures and implementations |
| Project files | Removed Microsoft.Identity.Abstractions package reference |
| API files | Updated public API surface to reflect ValidationResult usage |
pmaytak
reviewed
Aug 14, 2025
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
This was
linked to
issues
Aug 14, 2025
Closed
pmaytak
approved these changes
Aug 14, 2025
keegan-caruso
approved these changes
Aug 15, 2025
This was referenced Aug 15, 2025
Closed
This was referenced Apr 1, 2026
Closed
This was referenced Apr 9, 2026
This was referenced Apr 18, 2026
This was referenced Apr 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR returns to returning ValidationResult defined in IdentityModel.
This resolves issues:
Microsoft.IdentityModel.Tokens8.13.1 now depend onMicrosoft.Identity.Abstractions? #3290