Add expected Base64UrlEncoder.Decode overload for NET6 and 8#3250
Merged
Add expected Base64UrlEncoder.Decode overload for NET6 and 8#3250
Conversation
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
jennyf19
approved these changes
May 30, 2025
mdchennu
approved these changes
May 30, 2025
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
| return Decode(strSpan, output, decodedLength); | ||
| } | ||
| #elif NET6_0_OR_GREATER | ||
| internal static int Decode(ReadOnlySpan<char> strSpan, Span<byte> output) |
Contributor
There was a problem hiding this comment.
I would think we need to adjust the API files for this
Contributor
There was a problem hiding this comment.
It can be a follow up
keegan-caruso
approved these changes
May 30, 2025
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
This was referenced Jul 22, 2025
This was referenced Feb 9, 2026
Closed
This was referenced Feb 16, 2026
Closed
Closed
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3251
internal static int Decode(ReadOnlySpan<char> strSpan, Span<byte> output)withintreturn type for NET 6 and NET 8.Working notes which can be disregarded (just didn't want to lose them):