Skip to content

Implement and Test Audience and Lifetime validations in SamlSecurityTokenHandler with New Validation Model#2925

Merged
FuPingFranco merged 9 commits into
devfrom
francofung/ImplementNewModelValidationForSAMLAudience
Oct 22, 2024
Merged

Implement and Test Audience and Lifetime validations in SamlSecurityTokenHandler with New Validation Model#2925
FuPingFranco merged 9 commits into
devfrom
francofung/ImplementNewModelValidationForSAMLAudience

Conversation

@FuPingFranco

Copy link
Copy Markdown
Contributor

Implement and Test Audience and Lifetime validations in SamlSecurityTokenHandler with New Validation Model

Description

Similar to #2863 but in SamlTokenHandler.

  • Implement validateConditions method in for new SAML validation methods
  • Implement new ValidateTokenAsync method for SAML validation
  • Test Audience validation against old path.
  • Test Lifetime validation against old path.

Fixes #2885

@FuPingFranco
FuPingFranco requested a review from a team as a code owner October 18, 2024 02:11

@iNinja iNinja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments should be easy to address.

Could you please double check the stack frame caching in SAML2 in case this was brought from there?

@iNinja iNinja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FuPingFranco
FuPingFranco merged commit 69b15a7 into dev Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement and Test LifeTime in Saml Token Handlers Using New Token Validation Model

3 participants