Skip to content

Added properties to ValidationResult without throwing#2923

Merged
iNinja merged 1 commit into
devfrom
iinglese/add-non-throwing-properties-to-validation-result
Oct 18, 2024
Merged

Added properties to ValidationResult without throwing#2923
iNinja merged 1 commit into
devfrom
iinglese/add-non-throwing-properties-to-validation-result

Conversation

@iNinja

@iNinja iNinja commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

Added properties to ValidationResult without throwing

  • Added new nullable properties to ValidationResult without throwing exceptions.
  • Renamed IsSuccess to IsValid

Part of #2711

@iNinja
iNinja requested a review from a team as a code owner October 17, 2024 18:27
get
{
if (IsValid)
LogHelper.LogWarning("Warning: Accessing the Error property in a valid result is invalid.");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wonder if we should have this as an IDX message?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll raise an issue to review the messages and look into that as well.

@FuPingFranco FuPingFranco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNinja
iNinja merged commit b18623d into dev Oct 18, 2024
@iNinja
iNinja deleted the iinglese/add-non-throwing-properties-to-validation-result branch November 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add properties to retrieve Result and Error from ValidationResult without throwing

3 participants