Suggested changes to AudienceValidation

[brentschmaltz]

Changes to AudienceValidation to help with consistency:

1. Cache stack frames in AudienceValidationError to remove possibilitiy of use by other validators.
2. Pass tokenAudience and validateAudiences to AudienceValidationError for increased fidelity.
3. Attempt to resolve Exception in derived ValidationError first before calling base.
4. Add ValidationFailureTypes to describe errors with increased fidelity.
5. Use MessageDetail.NullParameter consistently for null parameter errors.

Some smaller items:
JsonWebTokenHandler set error to ValidationFailureType.SignatureAlgorithmValidationFailed, when algorithm is not valid.
LifetimeValidationError remove ctor that has inner validation error
Renamed IssuerValidationSource values to be more readable

[iNinja]

For the most part this is great. There is one point that I can't agree with without having a proper discussion with @jmprieur and @jennyf19, mentioned in the review.

[iNinja]

LGTM

[FuPingFranco]

LGTM, Thanks Brent!

[jennyf19]

For the most part this is great. There is one point that I can't agree with without having a proper discussion with @jmprieur and @jennyf19, mentioned in the review.

which is that?

[FuPingFranco]

Can we create a follow up issue to track this?