Skip to content

Fix typo#2894

Merged
westin-m merged 7 commits into
devfrom
westin/SamlTypo
Oct 22, 2024
Merged

Fix typo#2894
westin-m merged 7 commits into
devfrom
westin/SamlTypo

Conversation

@westin-m

Copy link
Copy Markdown
Contributor

Closes #1873

Tested with repro in bug

@westin-m
westin-m requested a review from a team as a code owner October 10, 2024 22:42

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19

Copy link
Copy Markdown
Contributor

wonder if this needs to be in a major version - thoughts @brentschmaltz ?

@pmaytak

pmaytak commented Oct 18, 2024

Copy link
Copy Markdown
Collaborator

wonder if this needs to be in a major version - thoughts @brentschmaltz ?

Does it work currently at all? Like xsi:Type? If yes, I suppose this could be a breaking change, since folks rely on this behavior.

@westin-m

Copy link
Copy Markdown
Contributor Author

Does it work currently at all? Like xsi:Type? If yes, I suppose this could be a breaking change, since folks rely on this behavior.

This works because xsi:type is what's expected. It's a runtime change, which I think should be fine to bring in.

@westin-m
westin-m merged commit 2858319 into dev Oct 22, 2024
@westin-m
westin-m deleted the westin/SamlTypo branch October 22, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Microsoft.IdentityModel.Xml.XmlUtil.GetXsiTypeAsQualifiedName searches 'Type' attribute instead of 'type'

4 participants