Use FixedTimeEquals in NETCore targets #2857
Merged
Merged
Conversation
kllysng
previously approved these changes
Sep 30, 2024
msbw2
approved these changes
Sep 30, 2024
Collaborator
|
Could you also run a small benchmark? |
Contributor
|
A similar change is needed for the ReadOnlySpan overload. |
|
Patche-2_Robledo6 |
Contributor
Are we okay with these benchmarks? Not sure if the results are as expected 🤔 |
Contributor
Author
|
Reopening this because our current code is getting optimized, which we don't want. |
pmaytak
approved these changes
Oct 8, 2024
pmaytak
left a comment
Collaborator
There was a problem hiding this comment.
Both of these methods are covered by tests?
Contributor
Author
Yes, there is already coverage. |
JoshLozensky
approved these changes
Oct 10, 2024
This was referenced Aug 6, 2025
This was referenced Jul 1, 2026
Merged
Merged
This was referenced Jul 10, 2026
Closed
This was referenced Jul 17, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2825
There is another class in wilson named CryptographicOperations, so the fully qualified name is necessary.
The following results are after applying NoOptimization