Skip to content

Uses spans for issuer comparison and fixes prior index out of range error#2826

Merged
sruke merged 2 commits into
devfrom
sruthi/Fix-index-out-of-range
Sep 19, 2024
Merged

Uses spans for issuer comparison and fixes prior index out of range error#2826
sruke merged 2 commits into
devfrom
sruthi/Fix-index-out-of-range

Conversation

@sruke

@sruke sruke commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

Why?
Improves performance during issuer validation by replacing string comparison with span comparison.

What?
The performance improvements were originally introduced in this PR that had to be reverted due an index out of range error. This PR reintroduces the changes and addresses the error.

@sruke sruke self-assigned this Sep 16, 2024
@sruke
sruke requested a review from a team as a code owner September 16, 2024 00:48
@sruke sruke added this to the 8.0.3 milestone Sep 16, 2024

@keegan-caruso keegan-caruso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sruke
sruke merged commit a9380ab into dev Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Reduce allocations in Aad validation by not using string.Replace when it isn't necessary

4 participants