Skip to content

Enable TimeProvider on New Model#2813

Merged
FuPingFranco merged 6 commits into
devfrom
francofung/enableTimeProvider
Sep 17, 2024
Merged

Enable TimeProvider on New Model#2813
FuPingFranco merged 6 commits into
devfrom
francofung/enableTimeProvider

Conversation

@FuPingFranco

Copy link
Copy Markdown
Contributor

Enable TimeProvider on New Model

Description

Enable TimeProvider on new Wilson model.

@iNinja

iNinja commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

@FuPingFranco
FuPingFranco marked this pull request as ready for review September 17, 2024 00:10
@FuPingFranco
FuPingFranco requested a review from a team as a code owner September 17, 2024 00:10
@FuPingFranco

Copy link
Copy Markdown
Contributor Author

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

I updated our new validation unit tests that required DateTime.UtcNow to use TimeProvider but decided to implement a MockTimeProvider instead as the FakeTimeProvider raises a new warning due to it being untested for net462.

@keegan-caruso

Copy link
Copy Markdown
Contributor

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

I updated our new validation unit tests that required DateTime.UtcNow to use TimeProvider but decided to implement a MockTimeProvider instead as the FakeTimeProvider raises a new warning due to it being untested for net462.

I don't understand, https://www.nuget.org/packages/Microsoft.Extensions.TimeProvider.Testing/8.9.1#dependencies-body-tab

Has a net462 target.

Comment thread build/dependenciesTest.props Outdated

@iNinja iNinja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Minor comment.

Comment thread build/dependenciesTest.props Outdated
@FuPingFranco
FuPingFranco merged commit d7a6547 into dev Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants